Dani Guardiola
Dani Guardiola
Since there are no evident breaking changes that affect us on changelog inspection, but we have many failing tests, I'm going to take another strategy. I will go version by...
Also ping @WordPress/gutenberg-components if you can take a look at failing tests in CI and see if anything rings a bell or if you have any ideas. Since you're more...
I have some unpushed fixes like that, let me push soon and I'll let y'all know so we can figure out any remaining cases.
@tyxla unless I missed something, the branch was synced with trunk yesterday. `waitFor` works in some instances; in others, it's a bit unclear what we should be waiting for that...
@ciampo yep, already on my backlog as a follow-up to this, thanks!
After investigation, it does NOT seem like the ariakit `render` utility supports rerenders properly: https://github.com/ariakit/ariakit/issues/3939#issuecomment-2251231903 Waiting on Diego to know if supporting re-renders is a possibility, since that'd help us...
Update 5 (see description) is a breakthrough! With re-render support in my temporary fork of Ariakit's `render`, all tests so far have been fixed :) Next up: apply the re-render...
Gonna use the local fork for now, but I'm aiming to contribute this to upstream Ariakit so we don't depend on our local fork, see https://github.com/ariakit/ariakit/issues/3939#issuecomment-2251499387
See last update (update 8) - 0.4.0 version makes a bunch of tests fail.