Dani Guardiola
Dani Guardiola
Check the [features.md file](https://github.com/DaniGuardiola/node-vault/blob/refactor/features.md) and you'll understand why using mustache is a really good idea, solving two problems in one: - Path parameter documentation - Path parameter substitution for request
**UPDATE: outdated list** So, current progress is: - [x] Use ES6 syntax - [x] ~Provide packages for different Auth backends~ (wontfix) - [x] Remove `mustache` - [ ] Provide better...
@StarpTech I explained how and why we are using `mustache` in [this comment](https://github.com/kr1sp1n/node-vault/issues/76#issuecomment-356264823) And I explained some of the advantages of using it in [this other comment](https://github.com/kr1sp1n/node-vault/issues/76#issuecomment-356265345) Each request needs...
Btw, you guys can help me with something, I need to finish adding documentation to [`features.js`](https://github.com/DaniGuardiola/node-vault/blob/refactor/src/interface/features.js) (for `features.md`). You can help me by checking that file and adding the documentation...
@StarpTech forming the url and inserting the parameters are two different things. The parameters are contained in the path. In the `request` method, the parameters are passed in `options.json`. Example:...
Re-read [my comment](https://github.com/kr1sp1n/node-vault/issues/76#issuecomment-356264823) and notice that there are two steps: forming the URI and inserting the parameters in the path. For the first step a template string literal works just...
I mean we could create a basic `mustache`-like function, but I don't know how convenient that would be. Basic substitution (just replacing variables by name) is easy, however the code...
I suppose what we need to implement are defaults to replace the inverted section usage. Then we can easily create a function with a similar interface to `mustache` + defaults,...
@kr1sp1n I got a question, if there's a parameters defined in the path without a default (`mustache` inverted section), and the value is not present, it should fail right? Otherwise...
For now this is the behavior I decided, not very happy with it but I think that is the current behavior with mustache anyway ``` it('should not fail if value...