Results 340 comments of Dan Gould

Because of our tangled arch this was difficult to verify even though it was probably resolved. Leaving this open until we have a proper test that a directory hosted with...

Love this idea but have no experience with mutation testing to offer

> what is exactly the purpose of test_mepool_accept(), why not directly try to broadcast directly? Because you want to make sure that you can broadcast the fallback, not actually effect...

I don't think it has anything to do with peers at all. [`testmempoolaccept`](https://developer.bitcoin.org/reference/rpc/testmempoolaccept.html) checks whether a tx passes consensus and policy code.

The receiver holds the fallback hostage to impose a cost on UTXO probing. If it'll never be able to be mined, it's useless. testmempoolaccept is a basic sanity check that...

Yes, and promote the change to allow the underlying access https://github.com/romanz/electrs/pull/1212

Yes getting multiple implementations to use a thing is kind of my whole shtick edit: Does Liana not use a primary electrum server? Is it calling out to random public...

sounds good to me. I hadn't considered the bitcoin-ffi release cadence. Crossing boundaries with primitives and validating at runtime sounds appropriate for the usecases in our medium-term roadmap. Perhaps bitcoin-ffi...

I think this is right but also there still other places this change is appropriate: `multiparty::{Sender,extract_v2,GetContext::extract_req,FinalizeContext::extract_req}`. I think that's it

multiparty::Sender::extract_v2 still takes a concrete `Url`. Please comb the codebase for the stragglers external passed should-be-urls that return errors that handle IntoUrl should be IntoUrl. Internal functions where `Url`s are...