payjoin
Use `IntoUrl` for `ohttp_relay` argument
Switching to IntoUrl makes the function more ergonomic by allowing a broader range of URL-like inputs. This also simplifies bindings, as strings can be passed directly without extra conversion.
Pull Request Test Coverage Report for Build 14668335342
Details
- 5 of 5 (100.0%) changed or added relevant lines in 2 files are covered.
- 2 unchanged lines in 1 file lost coverage.
- Overall coverage decreased (-0.03%) to 81.908%
| Files with Coverage Reduction | New Missed Lines | % |
|---|---|---|
| payjoin/src/send/mod.rs | 2 | 94.46% |
| <!-- | Total: | 2 |
| Totals | |
|---|---|
| Change from base Build 14668081009: | -0.03% |
| Covered Lines: | 5324 |
| Relevant Lines: | 6500 |
💛 - Coveralls
I think this is right but also there still other places this change is appropriate: multiparty::{Sender,extract_v2,GetContext::extract_req,FinalizeContext::extract_req}. I think that's it
I think this is right but also there still other places this change is appropriate:
multiparty::{Sender,extract_v2,GetContext::extract_req,FinalizeContext::extract_req}. I think that's it
Done!
multiparty::Sender::extract_v2 still takes a concrete Url. Please comb the codebase for the stragglers
external passed should-be-urls that return errors that handle IntoUrl should be IntoUrl. Internal functions where Urls are already parsed should remain as-is.