Lon Blauvelt

Results 63 comments of Lon Blauvelt

@kislyuk They're intentional. Changes were made to `tests/test_indexer.py` since the tests were incompatible with the updated `HTTPSignatureAuth.verify()` function, which has several new asserts that break our mocked stub tests. Added...

@amarjandu Of course you'd message just before I took a long trip. XD This will be merged in after ES is removed, since it only fails on the indexing tests...

@amarjandu `common.mk` was updated a while back, not sure if you missed that? The py3.6 -> py3.7 mention has been addressed, thanks!

@amarjandu Good point, I'll make those changes. Thanks.

Most of my testing was done with WDL. CWL often doesn't print the relevant "success" line in its logs that status is checking for: https://github.com/common-workflow-language/workflow-service/blob/master/wes_service/toil_wes.py#L263 This was written and merged...

This should be addressed in the code. If you try to add, say, your current user name to the docker group, but you are running on aws, it won't let...

It works on localhost:8080 just fine because they see the same users and groups, but that is not the case if the `wes-server` is hosted remotely.

@rtitle Thanks for looking into this. I'll try running it with the create app API and see how that goes next. I'm also transitioning to basing the image on `us.gcr.io/broad-dsp-gcr-public/terra-jupyter-r:2.0.1`...

> +1 vote for MIT which is what we use in [Cactus](https://github.com/ComparativeGenomicsToolkit/cactus/blob/master/LICENSE.txt) and [vg](https://github.com/vgteam/vg/blob/master/LICENSE) I support moving to MIT and a generally more permissive license.

One thing I should add, we need a better way of testing SLURM with MPI in toil.