⭐️NINIKA⭐️
⭐️NINIKA⭐️
> Should we consider case for filtering multiple events? I did initially dismiss this idea (because the previous design did not allow this), but I think it's actually pretty doable...
Instead of relying on an existing crate, I decided to implement a custom device macro on events for this. It gives us better control of the API we expose and...
> Generate a lot of warning which sohuld be fixed of muted if required. Done, added all the `#[must_use]` annotations and silenced the `clippy::match_same_arms` diagnostic
The call is [here](https://github.com/cesena/ghidra2dwarf/blob/7fc8990815cd24e8fe392572eee240bf88ebaf1f/lib/src/main/java/libdwarf/LibdwarfLibrary.java#L13) I believe. Here's a complete diff I used for my workaround: ```diff diff --git a/lib/fetch_libs_and_build.sh b/lib/fetch_libs_and_build.sh index d31b5e5..2917ba7 100755 --- a/lib/fetch_libs_and_build.sh +++ b/lib/fetch_libs_and_build.sh @@ -1,7 +1,7...
> And these are particular flaky tests: > integration::extra_functional::offline_peers::genesis_block_is_committed_with_some_offline_peers > integration::extra_functional::unstable_network::soft_fork Agree, I often find those particular tests failing. Though, a lot of client-cli-tests are also very flaky =(. I...
The peer executable should be renamed too then. Maybe `irohad`, like some common linux daemons?
I am curious what would be potential implications for the permissioned use-case. A single-purpose queries are simple to audit in the executor. See `FindAssetsByDomainId` for example: it's easy to forbid...
> Concern with permissioned queries which bothers me is that currently there is no restrictions to subscribe to blocks stream Huh, this is quite a huge loophole... Should just abandon...
For some of the queries (like `FindAccountsByDomainId` or `FindAccountsWithAsset`) we would need to introduce some additional filters, specific to the type of entity being filtered. In order to do that,...
A lot of the cases are done. Some other removals of queries are tracked in #4933.