CraftedRO
CraftedRO
https://www.wowhead.com/quest=10859/gather-the-orbs related.
After even more tests looks like for reaping (-49208), SpellFamilyMask1 is ignored completely, I can only guess that spell_dk_death_rune spell script doesn't properly check spell_proc/SpellFamilyMask1 in this case.
2c0ebbef1f5c051a104ef3ba74020b6e7bb2ccaa seems still valid.
cab8975c27888ccbcfd6a615cea86dc7e9138375 still valid.
Seems valid for [Escape Artist](https://www.wowhead.com/wotlk/spell=20589/escape-artist) too, this one doesn't work at all.
I think at the end of the day I will start closing issues that are already solved by pull requests, no point in having them opened.
3 weeks were more than enough to review a bool argument.
> 3 weeks were more than enough to review a bool argument. I starting to think this is that kind of intentionally left bug at this point, there's no any...
updated with values based on build: V4_4_0_54737, however seems like on blizz this 56422 Nerubian Submerge aura is not instantly re-applyed on npc when it evade but rather when it...
e6b9f215e9aece22446fc5b84363abbf5e2d9349 this most likely still require a spell script... Update with a recent vmangos attempt: https://github.com/vmangos/core/commit/e5070fbd3329b11d9705d4defd1182c870c34c9e