Victorien Elvinger

Results 332 comments of Victorien Elvinger

> It looks like a command to show lint errors subject to unsafe fixes. But here we should show an error incompatible arguments? For now, I could just throw a...

> It's still somewhere inside the doc comments and in the description of the PR. Could you please make sure to follow up? I still find that phrase opaque. I...

> It should suggest > ```js > flags._.[0] > ``` Are you sure about this? This looks like an invalid syntax as [reported by the TypeScript playground](https://www.typescriptlang.org/play/?#code/CYUwxgNghgTiAEYD2A7AzgF3gDwFzwG8AoeU+AfXxQFcBbAIxBgG0BdAGiIF8iiIQsAT3gBeHADpyzAAysA3HwHwAXqInlxM+UA). The suggested fix...

I think we could just skip the implementation of `exceptRange` and assume it is enabled.

Biome has the same behavior as Prettier here, however I accept that it is an undesirable behavior since we got a formatting instability. Thanks for reporting this!

> ne insight I can provide, that substring and slice are not identical Because of this we should certainly create a dedicate rule for [unicorn/prefer-string-slice](https://github.com/sindresorhus/eslint-plugin-unicorn/blob/main/docs/rules/prefer-string-slice.md)?

Same issue as #2003 and #2261. We decided to follow the [decision of TypeScript ESLint](https://github.com/biomejs/biome/issues/2003#issuecomment-2028665621).

The severity is set at the rule level? It could infer which one is an error using the rule name? We could also use a distinct color in the summary?...

> Should --summary keep the log that says "Checked 11 file(s) is 4ms"? I don't see any issue to keep it. I added it in the example.