Victorien Elvinger comments

Results 354 comments of


                                            Victorien Elvinger

💅 useFilenamingConvention errors on files starting with non-letter, a $ for example

> I'm not sure why we added exceptions for frameworks, but wouldn't it be better for users to ignore those files? I think we initially thought that there are not...

💅 useFilenamingConvention errors on files starting with non-letter, a $ for example

> This is not really a Remix thing, a $ or % or any other singular non-letter character can’t be subjected to camelCasing or uppercasing in any universe. Am I...

💅 `lint/complexity/noForEach` should not throw on `Effect.forEach` (or be configurable)

@nickrttn Why not disable the rule?

fix(analyze): check if a fragment has only one child element using tokens.

A test i s failing. According to it the following code shoudl also be rreporetd as useless: ```jsx foo ```

New `--enforceReadonly` compiler option to enforce read-only semantics in type relations

> we've had very few requests for readonly methods. It doesn't really seem to be a pain point, and mutation is commonly used in interception patterns, function prototype construction, etc....

📝 Format fails on parsing a catch clause with an union type even with formatWithErrors is set to true

If I understand correctly OP, `formatWithErrors` should ensure that formatting occurs even in the event of parsing error...

refactor: reduce memory footprint of Glob and Tokens

I just noticed that the repository is no longer maintained and is replaced by https://github.com/BurntSushi/ripgrep/tree/master/crates/globset If you are interested in this PR, I can do it for the maintained repository....

📎 Implement `lint/useMaxLinesPerFunction ` - `eslint/max-lines-per-function`

I could opt for the following name: `noExcessiveLinesPerFunction`. This is a more consistent naming (we already have [noExcessiveNestedTestSuites](https://biomejs.dev/linter/rules/no-excessive-nested-test-suites) and [noExcessiveCognitiveComplexity](https://biomejs.dev/linter/rules/no-excessive-cognitive-complexity)).

📎 Implement `lint/useMaxLinesPerFunction ` - `eslint/max-lines-per-function`

@mehm8128 Done :)

[Feature Request] Provide `Cursor` Implementation in `embedded-io`

This looks like a reasonable addition to me.