Victorien Elvinger comments

Results 332 comments of


                                            Victorien Elvinger

📝 Switch with fall through cases with comment gets fixed wrongly

The issue is now fixed :)

📎 Implement `nursery/noTsComment` - `typescript-eslint/ban-ts-comment`

@emab, If we follow the suggestion of @ematipico, I propose `noTsIgnoreComment` or `noIgnoreTsComment`.

Linter issues "This else clause can be omitted." when not applicable

Hi! The `else` clause of your playground example is actually useless. Indeed, your example: ```js function helloWorld(b: boolean) { if (b) { return 1; } else { return 2; }...

Linter issues "This else clause can be omitted." when not applicable

Yes, we changed a bit the behavior of `noUselessElse` in the 1.4.1 version to accept code like yours.

Linter issues "This else clause can be omitted." when not applicable

Good point. Have you some suggestions to improve the message?

Linter issues "This else clause can be omitted." when not applicable

The message was improved to `This else clause can be omitted because previous branches break early.`. Thanks for your help :)

📝 Biome's import sorting is being cancelled out by vscode's import sorting

Is the problem still there?

💅 False positive noUselessConstructor for changed data modifiers

Thanks for bringing this to light! We currently have no way of retrieving the accessibility modifier of the parent's constructor. The only way to fix this is ignoring claases that...

💅 False positive noUselessConstructor for changed data modifiers

> How difficult would it be to get access to inheritance chain? If the class is in the same file, it isp ossible. Otherwise, the infrastructure is currently uable to...

💅 False positive noUselessConstructor for changed data modifiers

Definitively! We should document this.