Victorien Elvinger comments

Results 332 comments of


                                            Victorien Elvinger

📎 Implement `noStaticOnlyClass`, @typescript-eslint/no-extraneous-class, unicorn/no-static-only-class

> Should this rule be under the style group? Maybe suspicious?

📎 Implement `noStaticOnlyClass`, @typescript-eslint/no-extraneous-class, unicorn/no-static-only-class

Ok **style** seems more adequate.

🐛VSCode extension stuck at 100% cpu usage

@unvalley This seems unlikely to cause the issue. The last nightly was released two weeks ago. Why do you think it is caused by this rule?

🐛 different reformatting for comments in default switch clause

Prettier had the same issue in its previous version (see on the [rome playground](https://docs.rome.tools/playground/?code=cwB3AGkAdABjAGgAKAA1ACkAewBkAGUAZgBhAHUAbAB0ADoAIAAvAC8AIABjAG8AbQBtAGUAbgB0ADUACgAvAC8AIABjAG8AbQBtAGUAbgB0ADUAYQAKAGIAYQByACgAKQA7AC8ALwBjAG8AbQBtAGUAbgB0ADUAYgAKAGIAcgBlAGEAawA7AAoAfQA%3D)). It is [now fixed in its current version](https://prettier.io/playground/#N4Igxg9gdgLgprEAuEBnA7gSxmAFgCgFYBKYAEzgDMBDAVwBsYkACAelecgFsuEZCAOlHacIPPoWpCARtQBO+YgG523XrELSZcuNQDWSoQF8QAGhAQADjEzRUyUPLkR0ABXkJ7KavXTUAnvbm0nLUYHpwMADK1LwAMphQcMg09KhwwaHhkVGWYYkA5sgwcrQZIHBc0nBkFGRx1FAFtNQFcABiEHJc1DA2TcggdDAQZiC4MFz0AOq42HCoeWBwUZ7YmABu2P6DYKhBIInpcjCuoQU9KT7p5gBWqAAeUYX0cACKtBDwV2nleXLHQayar0MaWOSJGDTTBkGC4ZAADgADOZwRB0tNQpZBuCFnA5BtkuYAI6feBnKxeIaoAC0SRqNTGOlJmB0Z1alyQqRuaEqmGKpXKqBecAAgn0IdJaOT8Qkkj8ecKmq8Pl9klzruUYNRpNDYfCkAAmcwlaiYeiFADCYk5FVQhDGtHSABUdV5ueUNmUAJJQCiwKJgCHWUV+qIwfyvBVwIxGIA).

🐛 `noRedeclare` does not report shadowed parameters by a local variable

Note: I think it is a bug related to the determination of the scope of the bindings.

feat(style/useConsistentArrayType): add rule

@eryue0220 Hi, are you still interested in the PR?

feat(style/useConsistentArrayType): add rule

I think it is ready for merging. Please run `just ready` to format/lint the code and generate missing files. Once CI is passing, we will be able to merge :)

📎 Allow empty type parameter list for interfaces and type aliases

> I wonder why such a thing is allowed Yeah, I dream of a simpler version of TypeScript... By the way, Flow forbids empty type parameter lists. Once fixed, we...

📝 The formatter cannot remove trailing commas in JSON files, unlike Prettier

I pretty like your idea @faultyserver. If @ematipico also agree we could open tasks to handle these cases as you suggested. I don't see any drawback to do that.

📝 The formatter cannot remove trailing commas in JSON files, unlike Prettier

I like this idea.