Victorien Elvinger comments

Results 332 comments of


                                            Victorien Elvinger

feat(rome_js_analyze): `noAssignInExpressions`

Ready for merging

feat(rome_js_analyze): `noAssignInExpressions`

My reasoning was that a recommended [rule could disallow sequences](https://github.com/rome/tools/issues/3932) (except in for updates and init). This seems good enough to my taste. However, I can update the code to...

feat(rome_js_analyze): `noAssignInExpressions`

> One problem I could see is that this rule will be recommended, while the suggested rule `no-sequence` is not part of the recommended rules from ESLint. Makes sense. I...

`noConstantCondition`, no-constant-condition

Assigned :)

`noDuplicateClassMembers`, no-dupe-class-members

The rule should be referenced by #3953

`noInnerDeclarations`, no-inner-declarations

@kaioduarte I am sorry I just noticed your comment. I thought that I was assigned to this issue. If you have already started the implementation, then I may withdraw my...

`noThisBeforeSuper`, no-this-before-super

I would like to implement this rule. :)

`noUnusedLabel`, no-unused-labels

I would like to implement this rule.

`noWith`, no-with

I have no answer for your issue. However, you can test your rule with a test. By default, there are in script mode if I am not wrong. You may...

`noSelfAssign`, no-self-assign

@ematipico What the status of `noSelfAssign`? Are there some missing parts?