biome icon indicating copy to clipboard operation
biome copied to clipboard

feat(style/useConsistentArrayType): add rule

Open eryue0220 opened this issue 1 year ago • 5 comments

Summary

Implement lint/style/useConsistentArrayType Fixed: #68

Test Plan

All existing tests has passed.

eryue0220 avatar Dec 10 '23 14:12 eryue0220

Deploy Preview for biomejs ready!

Name Link
Latest commit f4f353ebbbf6ff51cff310d786078d0a0071bfe4
Latest deploy log https://app.netlify.com/sites/biomejs/deploys/6593eed98ea7de0009f227fc
Deploy Preview https://deploy-preview-1137--biomejs.netlify.app
Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

Lighthouse
1 paths audited
Performance: 100 (no change from production)
Accessibility: 97 (no change from production)
Best Practices: 100 (no change from production)
SEO: 93 (no change from production)
PWA: -
View the detailed breakdown and full score reports

To edit notification comments on pull requests, go to your Netlify site configuration.

netlify[bot] avatar Dec 10 '23 14:12 netlify[bot]

Thanks for your contribution! This is greatly(大大) appreciated :)

I left suggestions. Feel free to ask details if it is not clear.

Many thanks for your patience reviewing and suggestions.

Sorry for the late reply.

eryue0220 avatar Dec 17 '23 09:12 eryue0220

@eryue0220 Hi, are you still interested in the PR?

Conaclos avatar Dec 23 '23 10:12 Conaclos

Yes, I'm still working on this PR.

eryue0220 avatar Dec 24 '23 06:12 eryue0220

@Conaclos Sorry for the late response before. And huge thanks to your suggestions and reviews. Merry Christmas.

eryue0220 avatar Dec 24 '23 10:12 eryue0220

CodSpeed Performance Report

Merging #1137 will not alter performance

Comparing eryue0220:feat/typescript-array-type (f4f353e) with main (658ffe9)

Summary

✅ 16 untouched benchmarks

🆕 77 new benchmarks

Benchmarks breakdown

Benchmark main eryue0220:feat/typescript-array-type Change
🆕 bootstrap.css[cached] N/A 240.1 ms N/A
🆕 pure.css[uncached] N/A 23.3 ms N/A
🆕 materialize.css[uncached] N/A 184.1 ms N/A
🆕 bulma.css[uncached] N/A 260.6 ms N/A
🆕 bootstrap.css[uncached] N/A 260.6 ms N/A
🆕 materialize.css[cached] N/A 170.3 ms N/A
🆕 full.css[cached] N/A 2.4 s N/A
🆕 full.css[uncached] N/A 2.5 s N/A
🆕 semantic.css[uncached] N/A 778.8 ms N/A
🆕 bulma.css[cached] N/A 240.8 ms N/A
🆕 foundation.css[uncached] N/A 166.6 ms N/A
🆕 package-lock.json[cached] N/A 32.1 ms N/A
🆕 tachyons.css[uncached] N/A 125.2 ms N/A
🆕 canada.json[cached] N/A 805.6 ms N/A
🆕 db.json[uncached] N/A 87.5 ms N/A
🆕 analyzer[index.js] N/A 171.3 ms N/A
🆕 eucjp.json[cached] N/A 4.3 ms N/A
🆕 db.json[cached] N/A 72.2 ms N/A
🆕 canada.json[uncached] N/A 1.1 s N/A
🆕 foundation.css[cached] N/A 156.3 ms N/A
... ... ... ... ...

:information_source: Only the first 20 benchmarks are displayed. Go to the app to view all benchmarks.

codspeed-hq[bot] avatar Dec 30 '23 17:12 codspeed-hq[bot]

I think it is ready for merging.

Please run just ready to format/lint the code and generate missing files. Once CI is passing, we will be able to merge :)

Conaclos avatar Jan 01 '24 15:01 Conaclos

Again. Huge Thanks to @Conaclos for your patience and your suggestion that I can ship this. It's a really wonderful travel.

eryue0220 avatar Jan 02 '24 13:01 eryue0220