gccrs icon indicating copy to clipboard operation
gccrs copied to clipboard

Fix line ending patterns in all `execute` testcases

Open CohenArthur opened this issue 1 year ago • 3 comments

The correct pattern for an end of line should be \r*\n+ to ensure compatibility with all platforms

CohenArthur avatar Jan 26 '24 17:01 CohenArthur

Can I just do sed -i -e 's/$/\r/' for each file in execute/ dir ?

badumbatish avatar Feb 29 '24 19:02 badumbatish

@badumbatish some of them are more correct than others, and some of them are also nested - but yes, this is basically it :) it's quite a simple issue, I'll mark it with good-first-pr

CohenArthur avatar Mar 01 '24 13:03 CohenArthur

is there a way to test that the changes I perform on these files would work?

Edited: I ran the tests and two are failing due to \r\n, i fixed it.

badumbatish avatar May 08 '24 04:05 badumbatish