Cœur
Cœur
The change in #729 may have cause a regression in the modified date of zipped files (https://github.com/zlib-ng/minizip-ng/issues/921), so I'll wait making a new release until I can confirm that and...
Yes, please wait for confirmation from @claraSophos or until I figure out a unit test that asserts that this is a clear improvement. I'll try to write one next weekend....
via cmake add_subdirectory()
You have the build logs link in my pull request description. The github action configuration is this one: https://github.com/transmission/transmission/blob/6a7ad3ff09361648407bd45d40c08eb08c7a789a/.github/workflows/actions.yml#L1005 It seems to be using ubuntu + vcpkg + `gradle build`...
And potential extra bug fix (regression in 4.0.8): - #930
In my use case (Transmission), yes: 1. We have libpsl as submodule under "third-party". 2. We do `add_subdirectory("third-party/libpsl" "${PROJECT_BINARY_DIR}/third-party/libpsl.bld")` https://github.com/transmission/transmission/blob/b372f7b193a2c02864af33093295d26b7caacfb7/CMakeLists.txt#L554-L555 https://github.com/transmission/transmission/blob/b372f7b193a2c02864af33093295d26b7caacfb7/cmake/TrMacros.cmake#L148
Is it still an issue in latest Carthage and latest ZipArchive?
The `MacOSX` string does not exist anywhere in this project. So that sounds more like you facing an issue with cmake or ninja than an issue with minizip. For better...
At least the file exists in newer SDKs for sure: ``` ➜ ls /Library/Developer/CommandLineTools/SDKs/MacOSX15.sdk/usr/lib/libz.tbd /Library/Developer/CommandLineTools/SDKs/MacOSX15.sdk/usr/lib/libz.tbd ➜ ls /Library/Developer/CommandLineTools/SDKs/MacOSX26.sdk/usr/lib/libz.tbd /Library/Developer/CommandLineTools/SDKs/MacOSX26.sdk/usr/lib/libz.tbd ``` Make sure you have Xcode 26 installed. And that `xcode-select...
My first line of text was: >So that sounds more like you facing an issue with cmake or ninja than an issue with minizip. Did you ask about that to...