Cœur comments

Results 652 comments of


                                            Cœur

Upgrade minizip to 4.0.7

done with #724

Using SSZipArchive to decompress found that the CPU skyrocketed more than 100%, causing the APP to crash

Please provide a sample file.

Using SSZipArchive to decompress found that the CPU skyrocketed more than 100%, causing the APP to crash

Those are iOS version numbers. Since you have access to the CPU usage, it means you were monitoring it with Xcode. Then please attach a crash report and an **Instruments**...

How to get the error?

This is not supported by the underlying minizip-ng. For `zip.open()` specifically, one of the possible failures is in `calloc` (not enough memory to allocate).

When creating zip file, UI freeze while app background to foreground.

Did you try to create the file on the UI thread or on a dedicated separate thread? Is it on iOS or macOS? If on iOS, did you correctly configured...

When creating zip file, UI freeze while app background to foreground.

Possible duplicate of #650.

cmake: better zlib-ng / zlib handling

@nmoinvaz @sgoth @fekstrom is that fine to merge this PR in its current state? I was thinking yes.

miniupnpd: `struct option` is incompatible with Darwin

ping @miniupnp

miniupnpd: potential dereference of NULL ; potential double free ; missing fclose

ping @miniupnp

When using createZipFileAtPath:savePath withFilesAtPaths:arrey, if there is a file and a folder in the array, the compression can be successful, but when decompressed, the folder becomes a 0-byte file and the folder cannot be opened.

If you can confirm it's a bug, then kindly try to offer a fix via a pull request.