Cœur

Results 652 comments of Cœur

@Rukario this isn't a complete list for 4.1.0 Beta: it's just the list of the most ready-to-merge pull requests. It will be easier to see what's left after those are...

@arcticfoxwpg, well, Charles and Mike do the work of code review (before merging), CI testing (on more systems than what GitHub Actions support) and release distribution. And they are trustworthy...

@ile6695 good catch, test updated

> Edit: The issue in question is #417. Ah, good test case: and indeed, my branch is **not** addressing #417 yet (zero-bytes files are shown, but not created). Let me...

Oh my my, it's quite non-trivial to have zero-bytes files being created: - if I comment out `if (file_size == 0)` in readOrWriteBytes, it creates zero-bytes files with extension `.part`...

OK, I figured it out. And no, @tearfur, we can't do it in `recheck_completeness()`, otherwise it creates the files before we even confirm that the torrent should be added or...

Ah, on macOS app, it is not possible to deselect zero-bytes files. So two more fixes are desired: 1. Make zero-bytes files de-selectable on macOS add window 2. Don't create...

But then you're "requesting" those files to your peers, when you could be "seeding" them directly instead.

@ile6695 I've limited the file creation to wanted files in 0c2991930bd0d534c4d10087c37dce5e8f625b32 @ckerr I've included your suggestion, to support changes in wanted files while the torrent is running, but it's not...