Chih Cheng Liang comments

Results 105 comments of


                                            Chih Cheng Liang

Required opcodes for advanced l2 bridge contracts

The remaining CREATE opcode is tracked in #1130 Meta issue can be closed for just 1 item left.

Write extcodecopy circuit

Yeah sure, sorry for the delay. Let me also tag @ed255 and @roynalnaruto because they've reviewed the spec.

Add missing circuits to benchmarks

@ed255 looks like all missing benches are done. Do we need exp circuit bench as in #980?

Write extcodecopy circuit

@DoHoonKim8 I checked and reproduced the testing error. It looks like the `external_address` is not written into the CopyTable, so the lookup failed. I traced the `assign_block` function, and the...

Write extcodecopy circuit

@roynalnaruto, the approach of populating bytecode to the table looks great. Thank you for the proposal!

Unify testing-randomness usage across the entire workspace

I'd say keep it simple before we get the challenge API.

Unify testing-randomness usage across the entire workspace

close for inactivity

optim/best-degree: set the optimal gate degree

Hi, @naure @ed255 @han0110 what's the status of this PR? Does anything need more clarification?

Meta: Refactor circuits to get randomness via challenge API

We can call this task done. We can create a new task for MPT when we reach there.

newbie question regarding how zkevm works

Close due to inactivity. Also, FYI, we have a new video on zkevm-circuit codebase released https://www.youtube.com/watch?v=01U8O2I3quI