Chih Cheng Liang
Chih Cheng Liang
I'm slightly leaning toward a trigger at release. When we redeploy there are usually minor or trivial bugs to investigate or fix, which might be annoying to fix frequently. But...
Adding onlyCoordinator to batchRegisterKey might solve an issue we have now. When people register a key on the BLSAccountRegistry, the client needs to sync that key to the database. There...
I did an update on the status of completion on 2023-04-28. Great work for all the progress :)
@lispc https://github.com/scroll-tech/zkevm-circuits/blob/2723b82fb5d538d6fcc7b2dd0d84d3df8818499f/bus-mapping/src/evm/opcodes.rs#L499 Looks fantastic! It would be great to upstream it. Update: #1612 is the issue
Hi @KimiWu123, I can reproduce this issue on my local side. It looks like the fix in #430 no longer worked. I also found that moving the configuration from setup.cfg...
Hi @protocolwhisper, the issue remains in the current main branch. The commit hash [999722f](https://github.com/privacy-scaling-explorations/zkevm-circuits/commit/999722fe638d14adc15fbc291c44792dd6ba07c3) is only used as a permalink to show the code block.
@protocolwhisper, let us know if you would like to take this task.
Hi @leolara, I reassigned to @protocolwhisper as this is a good first issue.
Hi @protocolwhisper, Yes, I've left some feedback on the PR.
I like the idea and I think we should do it. We can have more consistency in dependencies between crates. @ed255 or @KimiWu123, can you provide a second opinion on...