zkevm-circuits icon indicating copy to clipboard operation
zkevm-circuits copied to clipboard

Add missing circuits to benchmarks

Open ed255 opened this issue 3 years ago • 3 comments

We have benchmark tests defined here: https://github.com/privacy-scaling-explorations/zkevm-circuits/tree/main/circuit-benchmarks/src

We need to include the following circuits:

  • [x] PublicInputs #830
  • [x] Bytecode https://github.com/privacy-scaling-explorations/zkevm-circuits/pull/807
  • [x] Copy #899
  • [x] full Keccak #634
  • [ ] Exp Circuit https://github.com/privacy-scaling-explorations/zkevm-circuits/pull/980

ed255 avatar Aug 06 '22 10:08 ed255

We are working on it.

xiaodino avatar Sep 12 '22 14:09 xiaodino

@ed255 looks like all missing benches are done. Do we need exp circuit bench as in #980?

ChihChengLiang avatar Dec 12 '22 08:12 ChihChengLiang

@ed255 looks like all missing benches are done. Do we need exp circuit bench as in #980?

Thanks for reviewing this! We should have benches for all circuits. Let me extend this issue to include the Exp Circuit and once it's merged we can close this :)

ed255 avatar Dec 12 '22 13:12 ed255