Chih Cheng Liang

Results 105 comments of Chih Cheng Liang

I guess it's the network problem. Retry should be fine.

hi @konradkonrad , would it possible to elaborate more on this issue? It would be very helpful if the last workable version and the problem of the outdated client are...

Thanks @konradkonrad , it works perfectly for me.

Sorry, I checked the go-Ethereum again they don't check subgroup in bn256. https://github.com/ethereum/go-ethereum/blob/9efc1a847e53b63847f6f95e0857b1a6300786eb/crypto/bn256/cloudflare/bn256.go#L298

Could we leave `bls/api.py` as is, and put the wrapper in somewhere like `bls_binding/api.py`? For the license concern, I don't have experience in this either.

The next step of BLS signature API is to rewrite some performance hot spots with Cython or gmp lib. How do these kinds of optimizations fit into the upgrade?

benchmark before rename and pr feedback - profile_verify_multiple 177 sec - profile_verify_multiple_multiple 92 sec

@pipermerriam manually in this PR 😂`scripts/benchmark_multi_multi.py` https://github.com/ethereum/py_ecc/pull/67/files#diff-6603fa8fb24b1bbf0f65499a385162e4

Hi @Rumata888 and @carver, We moved the subgroup check outside of the `decompress_G2` after the refactor of #116 (cc @hwwhww). 1. For public key (G1), we perform the subgroup check...

Add explicit test to confirm this behavior for now.