Megan Wilhite
Megan Wilhite
@bdrung would you be willing to add a changelog and test coverage?
@major0 looks like there are some failing tests here.
@major0 are you able to come back to this one and fix the tests?
Closing due to inactivity. Please let me know if you want me to re-open this or feel free to re-open a PR against master with fixes to the failing tests.
bump @damonearp did you see @garethgreenaway 's comment?
I was not able to push to your branch. I opened a new PR that includes your commits and test coverage here: https://github.com/saltstack/salt/pull/62883 @calebj @whytewolf @garethgreenaway if you could review...
yes i did, apologies
bump @cebe can you respond to @garethgreenaway comment above?
@cebe can we close this PR In favor of https://github.com/saltstack/salt/pull/59280?
@cebe can you resovle the merge conflict? @garethgreenaway will this require tests or is there already test coverage for a change like this?