Megan Wilhite
Megan Wilhite
bump @tomdoherty did you see my review comments?
The only 3 remaining items is: 1. Get two more approvals. Since this PR does not have test coverage 2 other core members have to approve it not having test...
bump @tomdoherty did you see @waynew 's comment?
closing due to inactivity. Please let me know if this needs to be re-opened or open a new PR with a response to @waynew 's feedback.
pre-commit and lint are failing
I believe there might be something off with tabs or something else, because pre-commit is even showing it wants you to remove the entire line. When I locally tested adding...
For some reason I could not directly push to your branch so I opened a new PR but made sure to cherry-pick your initial commit. https://github.com/saltstack/salt/pull/62764 There was a tab...
Merging as tests passed previously before the changelog was added.
@whytewolf I went ahead and added a changelog file. Can you review please?
@ggiesen is this still a WIP?