Celtic Minstrel

There's a TODO comment for it in the code. It looks relatively simple to use the ANSI C signal handling facility, but I don't know if there's a better way...

Since EcEntryBase has a virtual function `print_value` but its destructor is non-virtual, this yields a compiler warning. I also get a compiler warning on Windows for the AbortLogger destructor (never...

Option to not catch SIGINT and SIGTERM

1

These signals don't necessarily represent an error condition, as they can be sent to request the program to shut down gracefully. Thus, I think it's strange that Loguru treats them...

Can't save unsigned integers

1

I tried saving a `uint64_t` and got a "Can't serialize type" exception. Even if you can't support uint64_t (not sure if the plist format can represent it fully), it seems...

Licensing?

3

There seems to be no license file in the repo, which technically means that no-one is allowed to use this in anything without explicit permission (presumably not your intent). Could...

These are the extra features that were pulled from #5663, as a draft for future reference.

Fix the issue with wesnoth.game_events.on_mouse_action

34

As described on the wiki, the action can trigger on the wrong hex if the mouse has moved during the callback. In addition to directly fixing this, I've added a...

Move generally-useful units to core so addons can use them

25

This moves many units from campaigns to core, allowing addons to safely use them without having to copy them into their own addon directory. The following units have been moved...

wesnoth.unit_types and wesnoth.terrain_types are now available in map generation scripts

3

For example, this could allow you to tailor a map to the movement of a specific unit type, or modify terrain based on properties rather than just the terrain code.