Tristan Grespinet

Results 65 comments of Tristan Grespinet

I'm pretty sure that Godot got some thread running in the editor to check if a file in the project was changed recently: https://github.com/godotengine/godot/blob/d5bd8a704f096043174af7994ef3de055a36cf45/editor/editor_file_system.cpp#L209. Need to investigate that more in...

We have plans for a @InjectNode (temporary name ) annotation if I remember but it's not going to be implemented in the immediate future. Here the draft Cedric made a...

Note for other References issues: - IsInstanceValid doesn't work for references because InstanceID is wrongly used - A new Reference created in Koltin only to be returned by a function...

LGTM But reminder that at some point we should rework everything related to systems and arch as it's becoming quite messy.

I agree, the point of being private is that we can't use them I'm just curious about that following. If they are private, why are they available in the API...

hum I'm confused. Isn't a method starting with an underscore is just to say that the function is virtual, not private, like _ready? ![image](https://user-images.githubusercontent.com/31470327/116788775-e602ba00-aaab-11eb-9951-776b832f1f9b.png) If this was really private, that...

yeah but it's still registered to the classDB: https://github.com/godotengine/godot/blob/8e68f2e5f48c66bfa80b9bb7746a488afb70086d/scene/gui/control.cpp#L2834 the true question: Can you call it from Gdscript ? if that's the case we should follow that as a reference

Is that really necessary to do it in Kotlin? Godot C++ already has functions ready to do such a conversion.

https://github.com/godotengine/godot/blob/dc98144b99f35cc6446e297e2c6082d8c441d540/core/ustring.cpp#L624 maybe you can use it as reference to do the right regex.

Not sure how to prevent this one. I have to test if a .gdignore would work but I doubt it. This can be a source of errors as well because...