Alex Eremin

Results 13 issues of Alex Eremin

Based on https://github.com/ROCmSoftwarePlatform/MIOpen/pull/2379#discussion_r1323596346 Currently `ConvSolver` initialized with `miopenStatusSuccess` by default, but it's not actually initialized with meaningful values: ```CPP ConvSolution(miopenStatus_t status_ = miopenStatusSuccess) : status(status_), solver_id(""), invoker_factory(boost::none), workspace_sz(0), grp_tile1(-1), grp_tile0(-1),...

quality

Based on https://github.com/ROCm/MIOpen/pull/2737#discussion_r1486010993 discussion. The project contains lots of copy-pasted functions like integer division with ceil rounding or various power of 2 checks, it would be nice to move that...

quality

Parse single binary gtest output and check that all the tests match [the naming scheme](https://github.com/ROCm/MIOpen/wiki/GTest-development). Verifies https://github.com/ROCm/MIOpen/issues/3133

GTest

It's an umbrella ticket for better tracking of GTest improvement activity ordered by priority. The tickets under the different checkboxes are independent and can be done in-parallel, while tickets under...

testing
urgency_high
GTest

Some of the test in a current test suite are intended to be unit tests, but for historical reasons they were implemented as integration, which included whole library pipeline, but...

GTest

Check all the tests that they are using appropriate assertion and tests generation functions as recommended [on the wiki](https://github.com/ROCm/MIOpen/wiki/GTest-development)

GTest

Some of the tests like layernorm (https://github.com/ROCm/MIOpen/blob/97ec5080860fd432b37e426bd3726cf6c8634b7a/test/gtest/addlayernorm.hpp#L102) have a special `operator

GTest

Remove environment variables from gtest (`MIOPEN_TEST_ALL`, `MIOPEN_TEST_FLOAT_ARG`, etc). This must be done simultaneously for all the tests and this issue switches old ctest scheme to the new one. It must...

complexity_high
GTest

Gtests are using random generator and setting internal library state based on environmental variables. It may work for a case `single binary-single test`, but will not work for a `single...

GTest

In order to switch to a new test invocation scheme, described [on the wiki](https://github.com/ROCm/MIOpen/wiki/GTest-development), the current [cmake test wrapper](https://github.com/ROCm/MIOpen/blob/97ec5080860fd432b37e426bd3726cf6c8634b7a/test/gtest/CMakeLists.txt#L19) should be updated with the following functionality: 1) generate custom regexp...

GTest