MIOpen icon indicating copy to clipboard operation
MIOpen copied to clipboard

Add approprite formatting function for gtests.

Open CAHEK7 opened this issue 1 year ago • 2 comments

Some of the tests like layernorm (https://github.com/ROCm/MIOpen/blob/97ec5080860fd432b37e426bd3726cf6c8634b7a/test/gtest/addlayernorm.hpp#L102) have a special operator<< for human readable tests case formatting.

A lot of the other cases do not have it and it should be added everywhere.

CAHEK7 avatar Jul 23 '24 17:07 CAHEK7

@CAHEK7 If the test case can be unambiguously described by the problem under the test, then we can re-use the serialization function, which should exist in each problem class. What do you think?

atamazov avatar Jul 23 '24 17:07 atamazov

@atamazov it will be generalized if the tests are using the same structure for the test cases or the structures are different, but compatible and can be printed via template function.

CAHEK7 avatar Jul 23 '24 18:07 CAHEK7

Closing since MIOpen is being migrated to ROCm/rocm-libraries. Please re-open there if you believe this is still an issue.

JonathanLichtnerAMD avatar Jul 29 '25 01:07 JonathanLichtnerAMD