Carlos Diaz

Results 219 comments of Carlos Diaz

> All compile time configuration options should be settable through CMake. Especially with the Linux/Embedded Linux platforms via the Linux Frame Buffer backend. It is extremely important that generating static...

> What if setting command mode means an extra byte in the communication or so. In this case it's part of how the data is being sent. I remember there...

Is it me or there's a missing `strcpy` at the end of this block when `LV_USE_ARABIC_PERSIAN_CHARS` is set to 0? Just after the realllocation on line 107 https://github.com/lvgl/lvgl/blob/2461ac0758eae69a94ee60a9be50d3de882ced09/src/widgets/label/lv_label.c#L85-L112 --- How...

In `lv_label_refr_text` there's two calls to `lv_anim_set_exec_cb(&a, set_ofs_x_anim);` when `LV_USE_BIDI` is set to 0. Is this expected? See last line of `else` and one line after `endif` https://github.com/lvgl/lvgl/blob/2461ac0758eae69a94ee60a9be50d3de882ced09/src/widgets/label/lv_label.c#L948-L959

@kisvegabor There are some methods that aren't tested directly by unit tests, but covered trough other tests, I'll add tests for those in the week.

I've ran [ravioli](https://github.com/ElectronVector/ravioli) and got this output: ```console $ ravioli -f src/widgets/label/lv_label.c ------------------------------------------------------------------------------- Functions complexity ------------------------------------------------------------------------------- src/widgets/label/lv_label.c:860 lv_label_refr_text 42 src/widgets/label/lv_label.c:273 lv_label_get_letter_pos 21 src/widgets/label/lv_label.c:384 lv_label_get_letter_on 19 src/widgets/label/lv_label.c:756 draw_main 19 src/widgets/label/lv_label.c:498 lv_label_is_char_under_pos...

> I'm sorry, somehow I didn't see your first comment... No problem, I've added the fix for `lv_label_refr_txt`. Here we are so far: ![imagen](https://user-images.githubusercontent.com/11037705/182995221-967b196c-6528-4561-bae9-c4d8bfb22b40.png) All of the selection related functions...

I haven't been able to figure out how to text the uncovered parts of the code, maybe some tips would be cool. Change the file extension of attached file to...

Fixed formatting error and opened #3573 to keep track of the suggested interface rename

Hi @arturo182, any update on this?