Carlos Diaz

Results 219 comments of Carlos Diaz
trafficstars

I've used CPPUTest, that as far as I know has a migration script from unity to CPPUTest. > use cmake instead of python script Also AFAIK the python script gathers...

Hi, yes I will take a look at it.

When changing ```c #define BTN_EXTRA_CLICK_AREA_MAX (LV_DPI_DEF / 10) ``` into ```c #define BTN_EXTRA_CLICK_AREA_MAX (LV_DPI_DEF / 10U) ``` And running the build test, the following error appear ```console lvgl/src/widgets/lv_btnmatrix.c: In function...

@kisvegabor What should happen if the user forgets to add the empty string at the very end of the map? ![imagen](https://user-images.githubusercontent.com/11037705/164363201-649302fd-1eae-4ee7-ae08-b0bf22a5e04f.png) --- What is being tested here? https://github.com/lvgl/lvgl/blob/1cf2e5d886c69ff5c16d08e42e28766ba9b2191e/src/widgets/lv_btnmatrix.c#L328

> > What should happen if the user forgets to add the empty string at the very end of the map? > > Fatal error :smile: I see no way...

@kisvegabor I've found this block of code repeated in several event handlers, what does it do? ```c if((button_is_click_trig(btnm->ctrl_bits[btnm->btn_id_sel]) == true || button_is_popover(btnm->ctrl_bits[btnm->btn_id_sel]) == true) && button_is_inactive(btnm->ctrl_bits[btnm->btn_id_sel]) == false && button_is_hidden(btnm->ctrl_bits[btnm->btn_id_sel])...

Will get back to this in the coming days. Sorry for disappearing, day job drawn me

I would like to finish adding unit tests for existing widgets and then clean up the first ones we did. Also improve the work flow when adding test cases. I'm...

The `some_spi_send_function` function may be replaced with something more generic like `some_interface_send_function` so the same display driver can be used with multiple interfaces, e.g. ILI9xxx displays can be used with...

> There is one question remaining: where to define display pinout? Should LVGL know about the pinout? Maybe something like this is enough (API is verbose on purpose), e.g. ILI9xxx...