Carlos Diaz

Results 219 comments of Carlos Diaz
trafficstars

on it The reference image looks a bit estrange tho, it has a roller in the top left, is it expected?

@kisvegabor I think the image comparison test is failing and making those CI to fail. Is there a way to run those specific CI steps locally?

@kisvegabor that worked, great feature!!

Is there anything missing so it can be merged?

It currently has this coverage ![imagen](https://user-images.githubusercontent.com/11037705/192395692-6cc01018-d2a3-481b-b20a-9f4a6766fd75.png)

I see it being executed, but not for `LV_INDEV_TYPE_POINTER` nor `LV_INDEV_TYPE_BUTTON`, I'll need to add the button one in the `lv_test_indev` files. ![imagen](https://user-images.githubusercontent.com/11037705/192925550-36708fe0-893d-4890-b0c3-6ca5869aba98.png) I'll add a test for the `LV_INDEV_TYPE_POINTER`...

I've added a test for the `LV_INDEV_TYPE_POINTER` indev which checks the selected option after clicking in the roller. Here's the current coverage: ![imagen](https://user-images.githubusercontent.com/11037705/193377810-c1b8ed7a-0e48-481a-8160-a5940c9f2b66.png)

Are you planning to update this test? https://github.com/lvgl/lvgl/blob/088b2bd49080cdd19e45d79bfd7e72e59f9bd6ec/tests/src/test_cases/test_dropdown.c#L50

It doesn't test anything (I'm looking at master), you're asserting 0 is equal to 0. ```c void test_dropdown_set_text_and_symbol(void) { TEST_ASSERT_EQUAL(0, 0); } ```

It should be nice to add tests for fixed bugs, first we need to add a test that replicates the bug (this test should fail), then we make the bug...