Boshen

Results 565 comments of Boshen

Babel revisits the AST https://github.com/babel/babel/blob/94e166782a37074d8c0031fc869f37e1b456194f/packages/babel-plugin-transform-typescript/src/const-enum.ts#L69 For us it should be adding enum data to semantic. ``` struct EnumTable { enums: FxHashMap } struct EnumData { symbol_id: SymbolId, scope_id: ScopeId, ......

> I'm thinking about implementing inline literal enum values across modules in rolldown. > > It would be good if oxc also collects non-const enum data. Rolldown could use this...

### Merge activity * **Apr 26, 11:07 PM EDT**: The merge label '0-merge' was detected. This PR will be added to the [Graphite merge queue](https://app.graphite.dev/merges?org=oxc-project&repo=oxc) once it meets the requirements....

https://oxc.rs/docs/learn/ecmascript/grammar.html#parenthesized-expression Nobody uses this in the real world so I didn't spend the time fixing it. It'll be some ugly hacks in the parser and codegen ... but only to...

As it turns out none of the tools (esbuild, swc, prettier, babel with prettify) preserve this semantic. I'm unwilling to implement this :-(

For context, it throws this if column number exceeds 400. https://github.com/oxc-project/oxc/blob/3df9e697ccf1944359edf3b94fe569eb5a00b364/crates/oxc_diagnostics/src/service.rs#L154-L159

An improvement should be print out the error message but don't print the code frame.

Made some improvements in https://github.com/oxc-project/oxc/pull/5120

Now that we have some of the implementation working, we should think about how to support the regex eslint rules 🤔

@preyneyv You may continue with https://github.com/oxc-project/oxc/pull/6847