Boshen
Boshen
> I'll try this. Thank you!
I see, thank you @fannheyward!
I can help with the changes, but I prefer a test infrastructure in-place first :grin: Probably running prettier tests with oxc-prettier-parser in CI?
> Yes, makes sense. Would you want to set that up, or shall I look into it? I'll look into it. > To change type names e.g.: I'll just change...
According the the prettier documentation, it seems like we just need to align with @typescript-eslint/typescript-estree: https://prettier.io/docs/en/options.html#parser * "typescript" (via [@typescript-eslint/typescript-estree](https://github.com/typescript-eslint/typescript-eslint)) First available in v1.4.0 By making a new package that...
hmm ... it's harder than I thought, it requires more information beyond just the AST https://github.com/prettier/prettier/blob/53111dd6553084c5108a10d5aa91d1c4bbb75454/src/language-js/parse/typescript.js#L15-L18
We have comments in an array, I'll get it returned to JS.
Released napi [email protected] * Returned comments * Renamed AST nodes: | TSESTree | OXC | | ----------------------- | ------------------ | | ArrowFunctionExpression | ArrowExpression | | NumericLiteral | NumberLiteral |...
Let me sit on renaming these spec names to estree names for a bit. I'm in favor of full estree compatibility but I need to think about the consequences and...
We reached the consensus of serializing to a estree compatible AST, all other issues can be raised separately.