Camillo Moschner

Results 36 comments of Camillo Moschner

Hi everyone, I am just reading through this PR and have to familiarize myself more with the PLR-integration of the OT-2. But, more generally speaking, I believe the agnostic `ThermocyclerBackend`...

Sorry, @rickwierenga, did you mean "Remove resources that **do not** have a catalogue number or other identifier"?

> one issue with making it a TypedDict is that volume correction becomes slightly more awkward, and the user needs to explicitly say > > ```python > lh.aspirate(vols=[hlc.correct(original_volume)]) > ```...

Hi @linx5o, > I therefore believe that this module should be 188049. I don't believe it is `188049` because... ![image](https://github.com/user-attachments/assets/f859c7ec-de14-4769-95cc-bbd7582d232a) ...cat no `188049` seems to refer to a plate_holder without...

Would you be okay with posting a picture of this multiflex module please? Then we can assess: - Does it have metal clamps? - You've named it "flat", does it...

No worries @linx5o, The pictures help a lot and we can figure this out :) --- > found by @ben-ray: > > ...I don't think it is this one because...

Note: Might I recommend renaming `MFX_WP_module_flat()` -> `Hamilton_MFXmodule_tall_flat()` (We haven't figured out a PLR naming convention for MFX Modules yet, but the first identifier should always be the manufacturer. So...

> @BioCam Could sloped be referring to the positioning guides along the side (The things that stick up to help guide the plate)? I can't really tell with 188228, but...

> `return PlateHolder( name=name, size_x=134.0, size_y=94.0, size_z=216 - 18.195 - 100,` I see, so you didn't change the `child_location` but instead changed the `PlateHolder`'s `size_x=135.0` -> `size_x=134.0` I recommend you...

Hi @linx5o, just checking in whether you have been able to verify the above plate_holder / "MFX Module" definition so we can update/merge this PR? :)