Benjamin Van Ryseghem

Results 133 comments of Benjamin Van Ryseghem

Thanks for the contribution. I'll have a look asap. Could it be possible in the meantime to make the CI pass?

Thanks for the report. Indeed, the unformatter is quite ambiguous and fails more that I dare to admit :smile: I would go for the second approach: - it matches better...

Thanks! Could you please add yourself to the AUTHORS.md file and add a line in CHANGELOG? Thanks again

yep, JS is not very accurate when it comes to float. But since we use BigNumber, we should be able to avoid this.

@all-contributors please add timfish for bug

thanks for the report :smile:

ok :smile: things are getting out of hand :smile:

Your PR can't be merged :smile: Could you have a look please?