Benjamin Van Ryseghem

Results 133 comments of Benjamin Van Ryseghem

Hi! Thanks for the PR :smile: A couple of things to change: - fix travis build, see [log](https://travis-ci.org/BenjaminVanRyseghem/numbro/jobs/600768888) - add yourself to the AUTHORS file - add a line in...

> This branch cannot be rebased due to conflicts Sorry

Thanks :) One final step :smile: - Could you please add yourself to the AUTHORS.md file? - Could you please add a line in the CHANGELOG file? - Could you...

![screen shot 2017-03-30 at 10 51 18](https://cloud.githubusercontent.com/assets/407891/24495869/d1e1bb98-1536-11e7-8d73-dbe5f177fcd2.png) You found a symbol not in my system font :smile:

I have no clue about the russian language :smile: But if I had to choose, I would try to stick to standards to be sure

That's just how javascript works....

Sounds like it can't hurt :smile: why the `k`?

ok. the code as to be a single character

@paravoid it's a bit hard to review as the code changed a lot. From what I have seen, the approach was quite good (I would have extracted the huge table...

Could you please rewrite your git history to get rid of the merge commits?