numbro icon indicating copy to clipboard operation
numbro copied to clipboard

Published 20 hours ago • verified publisher icon BenjaminVanRyseghem

fix unformat return type

Open ntduan opened this issue 4 years ago • 2 comments

https://github.com/BenjaminVanRyseghem/numbro/blob/develop/src/unformatting.js#L253-L282

The return value type of unformat is just number, which is not accurate because it is possible to return undefined.

ntduan avatar May 22 '20 03:05 ntduan

Thanks!

Could you please add yourself to the AUTHORS.md file and add a line in CHANGELOG?

Thanks again

BenjaminVanRyseghem avatar May 22 '20 08:05 BenjaminVanRyseghem

@BenjaminVanRyseghem hey - I was just about to PR this, this is a pretty big bug for TS developers, could you please look at merging it? Thanks

gc avatar Dec 26 '20 09:12 gc