Benjamin Brienen comments

Results 84 comments of


                                            Benjamin Brienen

Rust 1.83, allow -> expect (missing_docs)

I think you can use expect there if you use cfg_attr.

RCS1231 can cause perf implications and should probably be avoided in most scenarios when the struct is small

This lint is useful in performance critical code, where it can be manually enabled with a pragma, for example. 👍🏻

Vertically-centered text is too low

the number of pixels in height

Vertically-centered text is too low

But which is correct? 🤔

Add demo using bevy

This should be possible to play with now using Bevy/main.

Migrate to Anstyle

This would help our project if it were merged. Is this blocked?

Add `Commands::run_schedule`

> `commands.queue(|world| world.run_schedule(...))` We could make this a lint in bevy_cli to suggest simplifying the invocation.

AccessViolationException in ArrayDictionary

We also encountered this ``` ##[error]Fatal error. System.AccessViolationException: Attempted to read or write protected memory. This is often an indication that other memory is corrupt. at Microsoft.Build.Logging.StructuredLogger.BuildEventArgsReader.CreateDictionary(System.Collections.Generic.List`1) at Microsoft.Build.Logging.StructuredLogger.BuildEventArgsReader.ReadNameValueList() at...

Add Squircle primitive

Has merge conflicts. Still awaiting SME.

Add Squircle primitive

Based on the discussion on Discord, closing as wont-fix ![image](https://github.com/user-attachments/assets/6fd70019-5aee-483f-8094-688a17a0331e)