Benjamin Brienen

Results 83 comments of Benjamin Brienen

I guess the plugin needs a `max_delay: Duration` parameter.

How should this interact with single clicking? As in, do single clicks get delayed until the double click time has expired? Do both events happen?

I think the obvious answer is "both events happen", but I don't actually know how it is typically implemented.

I think there was an error in CI, maybe a merge conflict. Looks good now :) Edit: oh, it was the typo review comment

There are 3 examples of this false positive in the bevy repository. It doesn't trigger the false positive in the CI, which makes me think it's to do with the...

It does not trigger when I use msvc

Would this fix this issue? ```cs public void Setup(MarkdownPipelineBuilder pipeline) { if (pipeline.BlockParsers.Find() is HeadingBlockParser headingBlockParser) { // Install a hook on the HeadingBlockParser when a HeadingBlock is actually processed...

It suggests to invert that second if-block even though it wouldn't improve readability. This PR seems to add the concept of a "last if-block" and allows them.

Would this only affect primitives? Structs (which have default 0 values)? This refactor would be called something like " coerce default value" but "" isn't actually a default value and...

Is there a way to make folders of sorts? Group them by crate, module, or trait and select the group to expand the subcontext menu.