BenjaminAmos

Results 81 comments of BenjaminAmos

This isn't closed yet! Not all the issues have been solved.

Looking at this again, it seems like the maze collision issue was introduced in https://github.com/MovingBlocks/DestinationSol/commit/e5f6c68524ef8867d06c80c504bb127ccdde643a. The animated sprite code was never used after being implemented, so I've changed this PR...

This pull request reverts the code to a known state where it previously worked, so there shouldn't be much risk in merging it without further delay.

Debug engine builds have been built on Jenkins since https://github.com/MovingBlocks/DestinationSol/commit/ca0dc74c9d4ed2a3bd8c1f0fa0013c66c917ff2a, so this issue is partially fixed. Release builds are not handled though and neither are builds with non-core modules.

I should have mentioned before that https://github.com/MovingBlocks/TeraNUI/pull/66 and https://github.com/MovingBlocks/TeraNUI/pull/67 contain bug fixes that should help with testing this pull request.

There is another bug fix for NUI which allows this pull request to render correctly: https://github.com/MovingBlocks/TeraNUI/pull/69.

This was replaced by #668.

For non-code PRs like this, is there a way of skipping CI so that it doesn't waste resources when there's absolutely nothing new to test?

The `IK-2 Escort` ship is missing a `hirePrice` attribute, in-case anyone wants to fix this issue in the future. Since most ships seem to omit this attribute, it might be...

This doesn't appear to be an issue with the maze collision boxes themselves. In the Box2D editor the maze parts appear fine. I think that the collision shapes are being...