DestinationSol icon indicating copy to clipboard operation
DestinationSol copied to clipboard

NUI inventory screen

Open BenjaminAmos opened this issue 4 years ago • 2 comments

Description

This pull request converts the in-game inventory screen to use NUI. It should function almost identically to before, however it may look a bit different. Any UI design critiques would be appreciated also.

Testing

  • This pull request affects all screens that use the inventory's functionality.
  • The following screens are affected and should be double-checked against an older build to identify possible regressions:
    • TutorialManager
    • BuyItemsScreen
    • SellItemsScreen
    • ChangeShipScreen
    • ChooseMercenaryScreen
    • GiveItemsScreen (give items to a mercenary)
    • HireShipsScreen
    • ShowInventory (the "Items" screen)
    • TakeItems (take items from a mercenary)
  • As a guide, at least the following things should be checked:
    • Is the appearence similar to before (or better)?
    • Do all of the key-bindings work as before?
    • Does the screen function the same as before (or better)?

Notes

  • This depends on #631.
  • Until #631 is merged, it might be easier to view the changes made in this pull request by viewing the diff between the two of them at https://github.com/BenjaminAmos/DestinationSol/compare/nui-main-menu...nui-inventory-screen.

BenjaminAmos avatar Nov 05 '21 21:11 BenjaminAmos

I should have mentioned before that https://github.com/MovingBlocks/TeraNUI/pull/66 and https://github.com/MovingBlocks/TeraNUI/pull/67 contain bug fixes that should help with testing this pull request.

BenjaminAmos avatar Nov 06 '21 10:11 BenjaminAmos

There is another bug fix for NUI which allows this pull request to render correctly: https://github.com/MovingBlocks/TeraNUI/pull/69.

BenjaminAmos avatar Jan 13 '22 23:01 BenjaminAmos

This was replaced by #668.

BenjaminAmos avatar Sep 28 '22 20:09 BenjaminAmos