Ben Fradet comments

Results 114 comments of


                                            Ben Fradet

Rate Limiter is not based off the return headers from Riot. 429 Errors are not handled.

These two ideas seem pretty good to me. Regarding the first, does Riot provide useful values in the headers? iirc, there were pretty useless a while back

Rate Limiter is not based off the return headers from Riot. 429 Errors are not handled.

Also this might be two different issues as 429 need to be handled anyway

Requester - retry failed requests

This seems like a good idea given how unstable the API is.

Mock Requester during API unit tests

Sure :+1:

Mock Requester during API unit tests

That's no problem, looking great from what you're telling me :+1:

Mock Requester during API unit tests

There is no auth required to open PRs. I'd suggest you retry as this will greatly simplify the review process.

Documentation for DataRequested

AFAIK, there aren't really any documentation regarding those values. What would be nice is to document what is still returned when `none` is used (type, version, basic, data, id, name,...

Documentation for DataRequested

Oops, reopening as #232 only documented `none`.

Unit tests for the Requester

Additionally, mark the Requester class as internal explicitly.

That's the gist of it, yes. Basically, for each method in [Requester](https://github.com/BenFradet/RiotSharp/blob/develop/RiotSharp/Requester.cs), there should be unit tests. As an example, if we take [GetResult](https://github.com/BenFradet/RiotSharp/blob/develop/RiotSharp/Requester.cs#L50-L65) there should be two tests: -...