Ben Fradet
Ben Fradet
that could work, feel free to open a PR to update the version :+1:
what is `api` defined as? because `DataDragon` is part of `RiotApi`: https://github.com/BenFradet/RiotSharp/blob/develop/RiotSharp/RiotApi.cs#L62
it might be worth it to add this guide to the readme :+1:
yes the whole ci needs to be updated so that it passes, publishes a nuget and publishes the documentation
I'm :+1: on avoiding unnecessary exceptions
>As Cache and FileCache claim to do the same with different backend implementation it might be a good point to align both approaches regarding expiry. agreed :+1:
yup good idea :grin:
I think I like the modularity of one project per game more. This way, people can use what they need and only what they need.
feel free to open a PR :+1:
Yes riotsharp checks for rate limits and throttle requests, however I don't know if that still is the case when leveraging multithreading.