RiotSharp icon indicating copy to clipboard operation
RiotSharp copied to clipboard

Documentation for DataRequested

Open BenFradet opened this issue 8 years ago • 3 comments

The DataRequested doesn't have documentation regarding the enum values.

BenFradet avatar Mar 24 '16 21:03 BenFradet

Research for this led me to https://developer.riotgames.com/api/methods#!/1055/3633 which also just mentions the keys but not a good description on what they do which we can use for comments. I don't play LoL for me to really be descriptive about these things, would you know of any place where I can understand more and help document?

shrayasr avatar Jun 10 '16 08:06 shrayasr

AFAIK, there aren't really any documentation regarding those values.

What would be nice is to document what is still returned when none is used (type, version, basic, data, id, name, plaintext, group, and description for items for example) and what is added from that basic info for the other enum values and that all returns everything.

This made me realize that none is not really a good name and should be renamed to default (I created #231 as a result).

BenFradet avatar Jun 10 '16 12:06 BenFradet

Oops, reopening as #232 only documented none.

BenFradet avatar Jun 10 '16 14:06 BenFradet