Ben Fradet

Results 114 comments of Ben Fradet

if you share the same instance across your threads yes but I don't know how thread safe our code is.

Nope, I'll try to do it soon :+1:

Yes this is most likely a bug in how the wrapper is deserializing region and season, can you show a side by side between what's returned by `developer.riotgames.com` and the...

This is most likely due to the `SeasonConverter` not being used [here](https://github.com/BenFradet/RiotSharp/blob/76d40ec451a5d21a28f8132008acb6b5aaf868c6/RiotSharp/Endpoints/MatchEndpoint/MatchReference.cs#L57-L58), feel free to open a PR.

@Trigger-edge please pr against develop 👍

which documentation do you mean?

yes, I haven't had time to get to #489 yet, maybe this week :+1:

@averageprogrammer yup it'd be nice if you could have a look and review the other PR since you've done something similar :+1:

Sorry for the late review, haven't found the time yet, planning on doing it over the weekend :+1: