Matthias Becker
Matthias Becker
If somebody points me to a current description what needs to be done (I remember that some weeks ago the process with the binaries repo changed to LFS etc.) I...
I just also found e.g. https://github.com/eclipse-platform/eclipse.platform.swt/wiki/SWT-Developer-Guide#introduction which still describes the process with the two repos
I like this constructive discussion. You sorted out quite some points. Are they all somewhere documented in SWTs contributors guide? So that we can find this information easily again?
> I have used the following (CC-licensed) icons: > > * Whole Word: https://www.iconbolt.com/iconsets/codicons/whole-word > * Case sensitive: https://www.iconbolt.com/iconsets/codicons/case-sensitive > * Regex: https://www.iconbolt.com/iconsets/bootstrap-icons/regex > * Expand: https://www.iconbolt.com/iconsets/darkwing-free/right > * Collapse:...
> Since we cannot different icon sets based on themes (or can we?) No we can't. So they have to fit for both light and dark background.
> Maybe you have an opinion on these points or the proposed icons themselves? In case you have feedback to the user experience in general, that would also be great,...
> > Do you think both is needed? Wouldn't it be sufficient to only do the "multiple boxes" think because the "all" refers to multiple occurrences and not multiple letters....
> Maybe we could align that with the forward/backward search an replace icons? Good idea.
Would be good to have some unit tests for the changes. Also it would be nice if somebody on windows could test this PR.
Let's wait with version number increases once the freeze period is over and development for the next releases starts.