Alex Beaman comments

Results 184 comments of


                                            Alex Beaman

[hold for #51296] Write unit tests for updated `ReportActionItem` text depending on given `originalMessage` data

Oh good call 😅 You caaaan start writing tests if you want, but obviously they shouldn't pass till #49909 is merged 😬

[hold for #51296] Write unit tests for updated `ReportActionItem` text depending on given `originalMessage` data

Boom, PR merged!

[hold for #51296] Write unit tests for updated `ReportActionItem` text depending on given `originalMessage` data

Hmm I don't actually think the PR was created yet, 😅 @allgandalf have you started this yet?

[hold for #51296] Write unit tests for updated `ReportActionItem` text depending on given `originalMessage` data

aah funky! glad it's daily now :D and no worries for the delay, was just curious haha

[hold for #51296] Write unit tests for updated `ReportActionItem` text depending on given `originalMessage` data

Sounds good to me!

[$250] [Simple AA in NewDot] Update the approval chain / next receiver logic to handle correct optimistic next approver in Advanced Approval cases

cc @nkdengineer in case you're interested to work on this, since you worked on https://github.com/Expensify/App/issues/51001 recently

[$250] [Simple AA in NewDot] Update the approval chain / next receiver logic to handle correct optimistic next approver in Advanced Approval cases

Thank you @nkdengineer 👍 Please feel free to ask questions here before starting your PR IF you have any, either way I will try to do a very detailed review...

[$250] [Simple AA in NewDot] Update the approval chain / next receiver logic to handle correct optimistic next approver in Advanced Approval cases

Some problems I've seen so far in my testing - Note: I have the following setup: 1. Control policy, on Submit & Approve, default submitter is policy owner 2. 2...

[$250] [Simple AA in NewDot] Update the approval chain / next receiver logic to handle correct optimistic next approver in Advanced Approval cases

Ok I tested this a few times, and somehow my first test has the same bug I reported before, BUT I'm not 1000% sure if there was some bad setup......

[$250] [Simple AA in NewDot] Update the approval chain / next receiver logic to handle correct optimistic next approver in Advanced Approval cases

FYI backend PR was merged earlier today, hasn't been deployed yet