Alex Beaman comments

Results 184 comments of


                                            Alex Beaman

[$250] [Simple AA in NewDot] Update the approval chain / next receiver logic to handle correct optimistic next approver in Advanced Approval cases

@nkdengineer backend PR was deployed 🙏 please continue with this one & let me know if you hit any more bugs

[$250] [Simple AA in NewDot] Update the approval chain / next receiver logic to handle correct optimistic next approver in Advanced Approval cases

wtf... i see what you're seeing 🙃 @nkdengineer what approval mode have you been testing on? Me, Submit & Approve https://github.com/user-attachments/assets/b4dfefb7-9fa5-4c5a-baf6-b95f44963f9d

[$250] [Simple AA in NewDot] Update the approval chain / next receiver logic to handle correct optimistic next approver in Advanced Approval cases

Sounds good - you should be good @ntdiary as long as you'll be free early next week! I am working on fixing another internal bug 😬 https://github.com/Expensify/Expensify/issues/446644

[$250] [Simple AA in NewDot] Update the approval chain / next receiver logic to handle correct optimistic next approver in Advanced Approval cases

@nkdengineer FYI the bug I found is actually in Submit & Approve flows... Because we DO actually need to test that this all works in both Submit & Approve (S&A)...

[$250] [Simple AA in NewDot] Update the approval chain / next receiver logic to handle correct optimistic next approver in Advanced Approval cases

Okkkk that makes much more sense - thanks @nkdengineer 🙏 can you please test again on Advance Approval, and if it's working we can try to get the PR ready...

[$250] [Simple AA in NewDot] Update the approval chain / next receiver logic to handle correct optimistic next approver in Advanced Approval cases

Amazing, that's great to hear 👍 👍

[$250] [Simple AA in NewDot] Update the approval chain / next receiver logic to handle correct optimistic next approver in Advanced Approval cases

FYI backend PR merged now, may not get deployed till tomorrow - we'll see

[$250] [Simple AA in NewDot] Update the approval chain / next receiver logic to handle correct optimistic next approver in Advanced Approval cases

FYI backend PR merged now, may not get deployed till tomorrow - we'll see

Policy category - Add Payroll Code

I pre-reviewed a related PR, you know we need to write a lot of this in the detailed doc & get it approved first, right @rushatgabhane ? 🙏

[$250] Approver receives whisper when report is auto-approved on their behalf

Yeahhhh so I see your point and was thinking that could potentially work (check if the report _will_ get auto-approved in `SubmitReport`) - another solution which is definitely harder would...