Expensify
[hold for #51296] Write unit tests for updated `ReportActionItem` text depending on given `originalMessage` data
Background:
strongly encouraged suggestion: Write some automated tests to cover this change. It's a very good candidate for unit tests, and they'd go a long way to make this code more robust and avoid it breaking in the future.
That ^ suggestion was given here and I agree we should write unit tests for the changes in that PR 👍 I'm going to make this external b/c it would be great to get external help on this 🙏
Expected Result:
Please add unit tests for:
- UI tests rendering
<ReportActionItem>using@testing-library/react-native. - Additional
getReportNametests covering changes from https://github.com/Expensify/App/pull/49909
Triggered auto assignment to @Christinadobrzyn (Bug), see https://stackoverflow.com/c/expensify/questions/14418 for more details. Please add this bug to a GH project, as outlined in the SO.
![melvin-bot[bot] avatar](https://avatars.githubusercontent.com/in/179547?v=4 "Published by a pub.dev verified publisher"){kind=small}
Assigning @allgandalf from https://expensify.slack.com/archives/C02NK2DQWUX/p1728329535786379 🙏
@Beamanator should i wait for https://github.com/Expensify/App/pull/49909 to get merged ?
Oh good call 😅 You caaaan start writing tests if you want, but obviously they shouldn't pass till #49909 is merged 😬
Ooh - looks like PR is in production - https://github.com/Expensify/App/pull/49909
Adding a payment date to this GH.
Payment wasn't triggered - I think this is the right summary
Payouts due:
- [ ] Reviewer: $250 @allgandalf (Upwork offer - https://www.upwork.com/nx/wm/offer/104476390)
Do we need a regression test?
Hmm I don't actually think the PR was created yet, 😅 @allgandalf have you started this yet?
Hmm I don't actually think the PR was created yet, 😅 @allgandalf have you started this yet?
This was weekly and didn't show up on K2 for some reason, I will raise one today/tomorrow 👍
aah funky! glad it's daily now :D and no worries for the delay, was just curious haha
@Beamanator @Christinadobrzyn @allgandalf this issue was created 2 weeks ago. Are we close to a solution? Let's make sure we're treating this as a top priority. Don't hesitate to create a thread in #expensify-open-source to align faster in real time. Thanks!
@Beamanator here's the PR, do you have any review in specific ? I guess the unit tests would be fine(let me know if you need more), working on the UI tests now
update for Melvin - PR under review - https://github.com/Expensify/App/pull/51330
Reviewing label has been removed, please complete the "BugZero Checklist".
The solution for this issue has been :rocket: deployed to production :rocket: in version 9.0.60-3 and is now subject to a 7-day regression period :calendar:. Here is the list of pull requests that resolve this issue:
- https://github.com/Expensify/App/pull/52406
If no regressions arise, payment will be issued on 2024-11-20. :confetti_ball:
For reference, here are some details about the assignees on this issue:
- @allgandalf requires payment (Needs manual offer from BZ)
@allgandalf @Christinadobrzyn @allgandalf The PR fixing this issue has been merged! The following checklist (instructions) will need to be completed before the issue can be closed. Please copy/paste the BugZero Checklist from here into a new comment on this GH and complete it. If you have the K2 extension, you can simply click: [this button]
Wrong issue was linked here, @Christinadobrzyn can you please remove the hold for payment label here ? PR is still ongoing
yep! removed the payment information from the title. Let me know if you need me to do anything else!
@allgandalf can you link the PR we should be monitoring when you have a moment? TY!
watching PR https://github.com/Expensify/App/pull/51330
Going to move this to weekly since the PR is still under works.
@Christinadobrzyn @Beamanator lets put this one on hold for https://github.com/Expensify/App/issues/51296, in that issue we are making reportactionItem to be a pure component. I am the C+ on that issue, so i can start working on this one as soon as we merge that one