Alex Beaman
Alex Beaman
Sweeeeet they passed!! Hoping web will get to prod soonish so we can get this bad boi merged before the weekend 🙏
Hola! Hmm Performance tests are failing, I've seen that on other PRs recently - should we merge main & hope that fixes things? This PR doesn't look like it would...
Nice work here, y'all! 👍
Do you know exactly what is failing when inviting new members? If you can get it from `$modifyEmployeesResponse` that would be nice, but i haven't messed with `self::modifyEmployees` much, and...
This def does look like a dupe 👍 Also @CyberAndrii 's reproduction steps look pretty good in the other issue, would be nice if @Kalydosos could try to reproduce w/out...
> > would be nice if @Kalydosos could try to reproduce w/out their fix & with their fix > > They provide no fix afaik in https://github.com/Expensify/App/issues/51699, they just propose...
Thanks very much for confirming 🙏
Yo thanks for the ping, I was OOO last 4 days - will try to get to this today, if not I'll def get to this tomorrow
Hmm in my head i was thinking that "the same `lastUpdateID` would mean there's "no new Onyx updates we pulled" - but that doesn't necessarily mean the API response's onyx...
> However, OpenApp throws an error if we login to an account with Xero connected without 2FA enabled. Hmm yeah I might have to look into that actually, maybe that...