Aws0me
Aws0me
> > > Sounds partially like #4677, so this might be the same, although that was on Linux. I'm on Windows, but it does appear to be a similar issue.
> You made a typo. I checked again and I don't see it? Where is the typo so I can fix it?
> Also I disagree with how the fix is implemented. tmysql should be checked to see if it's an existing table before usage, but an error should still be thrown...
@Kefta that looks good to me, am I mistaken? ```lua local moo, tmsql = file.Exists("bin/gmsv_mysqloo_*.dll", "LUA"), file.Exists("bin/gmsv_tmysql4_*.dll", "LUA") ``` ```lua if MySQLite_config.Preferred_module == "tmysql4" and tmsql then ```
> Please note that MySQLite has its own repo: https://github.com/FPtje/mysqlite > > This is why the check-modified-subtree check fails. Do you want me to close this and make a PR...
@FPtje What do you think of the changes I just made? If they look good I will make the same changes on the mysqlite repo.
> Looks good for a PR on the other repo. I'll take a closer look later 👍 Made the PR in the other repo, I think it would be easiest...
Theoretically it would be slightly faster to just call next directly. However, in practice and with LuaJIT the difference is pretty much nonexistent. I figured most people would prefer to...